Openstack COS: Issue metrics even if runner creation fails #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkandersson
approved these changes
Jun 10, 2024
amandahla
reviewed
Jun 10, 2024
| @@ -794,7 +796,7 @@ def _create_runner(args: _CreateRunnerArgs) -> None: | |||
| security_groups=[SECURITY_GROUP_NAME], | |||
| userdata=cloud_userdata_str, | |||
| auto_ip=False, | |||
| timeout=120, | |||
| timeout=CREATE_SERVER_TIMEOUT, | |||
There was a problem hiding this comment.
Out of curiosity: when it fails by timeout, the server creation is aborted? Or could it fail by timeout but the server is still being created and at some point, is done and ready?
There was a problem hiding this comment.
I think it will not be cancelled, this is also the reason why we have a cleanup mechanism in those cases, but perhaps @yhaliaw can confirm.
yanksyoon
approved these changes
Jun 11, 2024
yhaliaw
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: n/a
Overview
reconcilemethod a bit.Rationale
Juju Events Changes
n/a
Module Changes
openstack_cloud.openstack_manager.OpenstackRunnerManager.reconcilehas been refactoredLibrary Changes
Checklist
src-docsurgent,trivial,complex)